Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering a materialx graph that includes an image node for reading in a texture with RenderMan the texture tiling is off as can be seen in the image below:
With the patch in this pull request the texture looks correct as seen below:
This test was done using the bishop_geom.usd from the USD Asset Working Group as the geometry. Then
color3
out
of the image node to the base color of the standard surfaceout
of the Standard Surface to thesurfaceshader
input of the Surface MaterialCreating the same MaterialX material in Solaris does not produce the same issue as what's seen here in QuiltiX.
While there weren't any adverse effects from this patch noticed in Storm for Metal, the patch that's presented in this pull request is most likely not the proper fix. But perhaps the info provided here is sufficient to identify the proper fix.
This was tested with: