Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in Bash strings #792

Merged
merged 1 commit into from
Oct 5, 2015
Merged

Fix regression in Bash strings #792

merged 1 commit into from
Oct 5, 2015

Commits on Oct 5, 2015

  1. Fix regression in Bash strings 

    In a recent patch the regex for single-quoted and double-quoted
strings of the Bash language was split into two separate regexes
to prevent the highlighting of variables inside of single-quoted
strings.

This causes a bug whenever a double-quoted string apears inside a
single-quoted string, because the double-quoted string is matched
first.

'"foo"'

The same problem exists with the newly introduced Here-Documents.
This patch fixes the problem by matching Here-Documents first and
merging the regexes for single-quoted and double-quoted
strings again.

This patch also adds testcases for this, to prevent future
regressions.
    @zeitgeist87
    zeitgeist87 committed Oct 5, 2015
    Configuration menu
    Copy the full SHA
    256c3e1 View commit details
    Browse the repository at this point in the history