Improve performance by doing more work in the worker #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the worker tokenizes the code and then turns it into a JSON string. This JSON string is sent back to the main thread as a message and parsed. Then it is turned into a HTML string and stored in the attribute env.highlightedCode. These conversions into JSON are unnecessary, because we can create the HTML string directly in the worker and send it as a message to the main thread. Signed-off-by: Andreas Rohner <andreas.rohner@gmx.net>
|
Hi! Nice catch, indeed. Thanks for contributing! |
Golmote
added a commit
that referenced
this pull request
Sep 24, 2015
Improve performance by doing more work in the worker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the worker tokenizes the code and then turns it into a
JSON string. This JSON string is sent back to the main thread as a
message and parsed. Then it is turned into a HTML string and
stored in the attribute env.highlightedCode.
These conversions into JSON are unnecessary, because we can create
the HTML string directly in the worker and send it as a message to
the main thread.
Signed-off-by: Andreas Rohner andreas.rohner@gmx.net