Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #464 crlf issue #466

Merged
merged 1 commit into from
Jan 11, 2015
Merged

fixes #464 crlf issue #466

merged 1 commit into from
Jan 11, 2015

Conversation

vkbansal
Copy link
Contributor

Before:
capture2

After:
capture3

LeaVerou added a commit that referenced this pull request Jan 11, 2015
@LeaVerou
Merge pull request #466 from vkbansal/fix-crlf
bf66348 
fixes #464 crlf issue
@LeaVerou LeaVerou merged commit bf66348 into PrismJS:gh-pages Jan 11, 2015
@LeaVerou
Copy link
Member

Thanks, merged!

Which browser did this issue happen in?

@vkbansal
Copy link
Contributor Author

Tested on IE11, Firefox (Stable and Developer Edition), Opera and Chrome on Windows.

@vkbansal
Copy link
Contributor Author

BTW. Can you fix the CSS for tab in this plugin? The empty space after the tab symbol is kind of misleading.

@LeaVerou
Copy link
Member

No, I was asking in which browsers the original bug was present, not in which ones you tested that the fix works.

@vkbansal
Copy link
Contributor Author

The problem was in all of them.

@vkbansal vkbansal deleted the fix-crlf branch January 12, 2015 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkbansal @LeaVerou