Update node.js workaround from global → globalThis #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the node.js global object is deprecated in favor of the cross-platform standard globalThis object. references: • https://nodejs.org/api/globals.html#global • https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first of all, i saw in the readme that Prism v2 is in the works and any ESM compatibility fixes it brings will undoubtedly fix the issue i am currently running into. however, the Roadmap for Prism v2 hasn’t been updated since august 2022, so in the meantime, i propose this as a very simple update to make prism’s node.js compatibility hack (introduced in #754) work with non-node.js runtimes that don’t have a
globalobject (e.g. workerd).also, the node.js
globalobject has been deprecated in favor of the cross-platform standardglobalThisobject, so making this update brings the workaround up-to-date with the latest standards.an alternative approach to this improvement would be to do something like:
…which i’m happy to implement if that would be preferable.