Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previewers: Use classList instead of className #2787

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

RunDevelopment
Copy link
Member

I changed Previewers to use classList instead of className. This makes the code easier to understand and less error-prone. Since classList.add will automatically filter dup classes, #2699 is also fixed.


This fixes #2699.

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of -40 B (-1.3%).

file master pull size diff % diff
plugins/previewers/prism-previewers.min.js 3.02 KB 2.98 KB -40 B -1.3%

Generated by 🚫 dangerJS against a8c7aa3

@RunDevelopment RunDevelopment merged commit d298d46 into PrismJS:master Mar 17, 2021
@RunDevelopment RunDevelopment deleted the previewer-classlist branch March 17, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flipped class added multiple times
1 participant