-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode characters in CSS properties #1227
Conversation
Highlight Unicode characters in CSS properties correctly, for example “.foo { --bär: 3 }”. Optimized the “function” regex in the JavaScript definition: replaced “_a-zA-Z0-9” with “\w”, removed uppercase “A-Z” because the “i” flag is set. Used that regex for CSS but removed “$” and added “-”.
Hi! Thanks for contributing. Could you run Also, can you update the test file for CSS properties with an example using unicode characters, and make sure it passes? You can use |
Do I need to install Gulp and NPM, eh? |
Added a test (and fixed indentation). |
Yes, indeed. |
I have not use them ever. When I have installed both do I just |
You need to |
Added minified versions, and tests passed. |
Awesome thanks! Can you add the |
This reverts commit 241464b.
Great! Looks good to me. Thanks again for contributing! |
In previous commit, #1227, a “function” regex JavaScript definition was updated. The same regex is used in few more points, and this PR optimizes them too. Tests are ran and passed.
Highlight Unicode characters in CSS properties correctly, for example
.foo { --bär: 3 }
.Optimized the “function” regex in the JavaScript definition: replaced
_a-zA-Z0-9
with\w
, removed uppercaseA-Z
because thei
flag is set.Used that regex for CSS but removed
$
and added-
.