Fix regression in Bash strings #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a recent patch the regex for single-quoted and double-quoted strings of the Bash language was split into two separate regexes to prevent the highlighting of variables inside of single-quoted strings. This causes a bug whenever a double-quoted string apears inside a single-quoted string, because the double-quoted string is matched first. '"foo"' The same problem exists with the newly introduced Here-Documents. This patch fixes the problem by matching Here-Documents first and merging the regexes for single-quoted and double-quoted strings again. This patch also adds testcases for this, to prevent future regressions.
|
The regression was introduced by my latest patch series for the Bash language. Sorry for the mess :( |
|
Thanks for fixing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent patch the regex for single-quoted and double-quoted
strings of the Bash language was split into two separate regexes
to prevent the highlighting of variables inside of single-quoted
strings.
This causes a bug whenever a double-quoted string apears inside a
single-quoted string, because the double-quoted string is matched
first.
'"foo"'The same problem exists with the newly introduced Here-Documents.
This patch fixes the problem by matching Here-Documents first and
merging the regexes for single-quoted and double-quoted
strings again.
This patch also adds testcases for this, to prevent future
regressions.