Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Invisibles: Problems with modifying grammars #1609

Open
RunDevelopment opened this issue Nov 12, 2018 · 1 comment
Open

Show Invisibles: Problems with modifying grammars #1609

RunDevelopment opened this issue Nov 12, 2018 · 1 comment
Labels
bug plugins

Comments

@RunDevelopment
Copy link
Member

RunDevelopment commented Nov 12, 2018 •
edited
Loading

Because Show Invisibles modifies the language definition itself, there might be problems with:

  1. The rest property is "unfolded" after we add the patterns for ICs which results in the tokens of rest being highlighted after the IC tokens.
  2. Other plugins (e.g. Autolinker) also modify language definitions at run-time (meaning via hooks). Show Invisibles has to be run after these plugins to be compatible. (Show Invisibles: Corrected load order #1612)
@RunDevelopment RunDevelopment mentioned this issue Nov 12, 2018
Merged
mAAdhaTTah pushed a commit that referenced this issue Dec 1, 2018
@RunDevelopment @mAAdhaTTah
Corrected load order of Show Invisibles (#1612)
6e0c6e8 
Correct the load order of Show Invisibles, Autolinker, and Data-URI Highlight,
so that Show Invisibles is loaded after the others.

Details in #1609.
ggrossetie pushed a commit to ggrossetie/prism that referenced this issue Mar 11, 2019
@RunDevelopment @ggrossetie
Corrected load order of Show Invisibles (PrismJS#1612)
9f1ded7 
Correct the load order of Show Invisibles, Autolinker, and Data-URI Highlight,
so that Show Invisibles is loaded after the others.

Details in PrismJS#1609.
@RunDevelopment RunDevelopment changed the title Show Invisibles: Potential problems Show Invisibles: Problems with modifying grammars Dec 5, 2021
@RunDevelopment
Copy link
Member Author

I finally happened. Show Invisibles modify grammars broke something. Details here: #3273.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug plugins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RunDevelopment