JSON highlighter mistake

[kvz]

Hi, thanks so much for Prism, we're loving it at Transloadit.

Think I may have found a bug in the JSON parser in case that's helpful. It appears to me that when a value contains a colon, it's mistaken for a key.

Here's a screenshot where it gets confused when a value is :original

And here's the full code used, for convenience:

{
  "steps": {
    "imported": {
      "robot": "/s3/import",
      "result": true,
      "key": "xxx",
      "secret": "xxx",
      "bucket_region": "us-east-1",
      "bucket": "demos.transloadit.com",
      "path": "my_folder/snowflake.jpg"
    },
    "exported": {
      "use": ["imported", ":original"],
      "robot": "/s3/store",
      "key": "YOUR_AWS_KEY",
      "secret": "YOUR_AWS_SECRET",
      "bucket_region": "us-east-1",
      "bucket": "demos.transloadit.com"
    }
  }
}

Using prismjs via npm, version: 1.8.1 which is the latest version at the time of writing

[Golmote]

Thanks for reporting. It should be fixed now. It will be in next release.

[kvz]

Excellent, thanks so much for the quick fix 👌

Would that be 1.8.4? I just upgraded to 1.8.3 but noticed the same behavior still

[Golmote]

Yes, it's 1.8.4. I just released it now.

[kvz]

Awesome! That fixed it: https://transloadit.com/demos/video-encoding/encode-for-ipad/ :tada: :smile:

…

-- Kevin van Zonneveld (kvz.io) Co-founder at Transloadit (transloadit.com) Core-author of tus (tus.io)

On 5 November 2017 at 17:41:16, Golmote ***@***.***) wrote: Yes, it's `1.8.4`. I just released it now. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #1204 (comment)