Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

twilio_phone_number.sms.primary_url not implemented #20

Closed
mleonhard opened this issue Sep 12, 2019 · 1 comment
Closed

twilio_phone_number.sms.primary_url not implemented #20

mleonhard opened this issue Sep 12, 2019 · 1 comment
Projects

Comments

@mleonhard
Copy link

mleonhard commented Sep 12, 2019

I'm running Terraform 0.12.8 with terraform-provider-twilio built with #19 . I added a new phone number to my config and applied it. Twilio shows the new number but it never got the SMS webhook URL configured.

I changed the webhook URL value and terraform apply fails:

module.test_helper.twilio_phone_number.number: Modifying... [id=nnnnnnn]

Error: Not implemented

Here is the config, with irrelevant parts removed or redacted:

$ terraform version
Terraform v0.12.8
...
+ provider.twilio (unversioned)
$ terraform show
...
# module.test_helper.twilio_phone_number.number:
resource "twilio_phone_number" "number" {
    country_code  = "US"
    friendly_name = "com-company-dev-phone-number"
    id            = "nnnnnnnnnnnnn"
    number        = "+1415nnnnnnn"
    search        = "415"

    sms {
        primary_http_method = "POST"
        primary_url         = "http://com-company-dev-phone-number-eb-env.nnnnn.us-west-1.elasticbeanstalk.com/twilio_webhook"
    }
}
$ cat main.tf 
...
resource "twilio_phone_number" "number" {
  friendly_name = "${var.instance_name}-phone-number"
  country_code  = "US"
  search        = "415"
  sms {
    primary_url         = "http://${aws_elastic_beanstalk_environment.default.cname}/twilio_webhook"
    primary_http_method = "POST"
  }
}

output "phone_number" {
  value = "${twilio_phone_number.number.number}"
}
$ terraform plan
Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.

...
module.test_helper.twilio_phone_number.number: Refreshing state... [id=nnnnnnnnnn]

------------------------------------------------------------------------

No changes. Infrastructure is up-to-date.

This means that Terraform did not detect any differences between your
configuration and real physical resources that exist. As a result, no
actions need to be performed.
@mleonhard mleonhard changed the title twilio_phone_number.sms.primary_url value not set on newly purchased number twilio_phone_number.sms.primary_url ignored Sep 12, 2019
@mleonhard mleonhard changed the title twilio_phone_number.sms.primary_url ignored twilio_phone_number.sms.primary_url not implemented Sep 12, 2019
@Preskton Preskton added this to To do in Basic MVP via automation Oct 12, 2019
@Preskton Preskton moved this from To do to In progress in Basic MVP Oct 12, 2019
@Preskton
Copy link
Owner

Just about to merge in #26 which should cover this! Thanks for submitting the report & thanks for your patience! :)

Preskton added a commit that referenced this issue Oct 12, 2019
Phone numbers now pretty much usable! 🎉

- Create, Update, and Delete fully functional (#3)
- Finding phone numbers
  - Search by area code
  - Free form sequence search
- Configuration settings
  - Voice Settings
    - Application SID (#4)
    - Primary and fallback URLs and methods (#20)
    - Caller ID enabled/disabled
    - Line receive mode - voice/fax
  - SMS Settings
    - Application SID
    - Primary and fallback URLs and methods
  - Status callback
    - URL and method
  - Emergency calling (not fully tested, as I don't have a validated Address at the moment)
    - Address SID
    - Status
@Preskton Preskton moved this from In progress to Done in Basic MVP Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Basic MVP
  
Done
Development

No branches or pull requests

2 participants