First wave of build/test updates #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and also unfinished about topic
|
|
||
| <ModuleVersion>1.1.2</ModuleVersion> | ||
|
|
||
| <ArtifactsPath>$(MSBuildThisFileDirectory)artifacts</ArtifactsPath> |
There was a problem hiding this comment.
What a funny variable. I looked it up and sure enough MSBuildThisFileDirectory "Include[s] the final backslash in the path."
| additionalParams.Add("Verbose", verboseEnabled); | ||
|
|
||
| return additionalParams; | ||
| } | ||
|
|
||
| private static T GetPropertyValue<T>(object value, string propertyName, T defaultValue = default) |
There was a problem hiding this comment.
Was this added in order to replace a library?
|
I can't seem to get Pester running (yes even after updating and importing Pester 5) or the package task to work. Will ping you Monday. |
|
Thank you so much for getting this started Patrick! Honestly you figured out the things I was going to have issues with (what with the dynamic removal, nuspec, and directory props artifacts thing), worked out great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Haven't touched the pipeline stuff yet, just getting the build script in order.
Also updated the tests to be Pester 5 compatible.
PR Context