Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(err): r/error-tracking/cymbal/g #25358

Merged
merged 1 commit into from
Oct 3, 2024
Merged

feat(err): r/error-tracking/cymbal/g #25358

merged 1 commit into from
Oct 3, 2024
+35 −28

Conversation

oliverb123
Copy link
Contributor

@oliverb123 oliverb123 commented Oct 3, 2024 •
edited
Loading

Problem

error-tracking is a mouthful

The solution

bad puns

I swear I'm actually writing the chart while I do this

daibhin
daibhin approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@daibhin daibhin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually against code names but... for the sake of a good pun

@oliverb123 oliverb123 merged commit 54dc40b into master Oct 3, 2024
89 checks passed
@oliverb123 oliverb123 deleted the olly_err_rename branch October 3, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

@neilkakkar neilkakkar Awaiting requested review from neilkakkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverb123 @daibhin