Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rework plugin server redis configs #25342

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix: Rework plugin server redis configs #25342

merged 2 commits into from
Oct 3, 2024

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Oct 2, 2024 •
edited
Loading

Problem

Second attempt at #25328

Changes

  • The issue before was in the cdp that it failed to start up due to pubsub issues. It looks like missing env vars meant it fell back to the REDIS_URL but thats for sure not what we want. Need to debug to figure out why before merging
    • fixed it - the redis picker was missing breaks in the switch statement. Reworked it and added tests.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite marked this pull request as ready for review October 3, 2024 07:46
pauldambra
pauldambra approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pauldambra pauldambra mentioned this pull request Oct 3, 2024
Merged
@benjackwhite benjackwhite merged commit 02bf6bb into master Oct 3, 2024
90 checks passed
@benjackwhite benjackwhite deleted the revert/plugin-server-redis-rework branch October 3, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjackwhite @pauldambra