Nova Scotia Basic personal amount #407
Open
+118
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yaohhhh <Yaohhhh@users.noreply.github.com>
...rameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/additional_amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_credits.py
Outdated
Show resolved
Hide resolved
Yaohhhh
reviewed
Jul 24, 2023
...da/parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/basic_amount.yaml
Outdated
Show resolved
Hide resolved
Yaohhhh
reviewed
Jul 24, 2023
...parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/applicable_rate.yaml
Outdated
Show resolved
Hide resolved
Yaohhhh
reviewed
Jul 24, 2023
...rs/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/higher_income_threshold.yaml
Outdated
Show resolved
Hide resolved
Yaohhhh
reviewed
Jul 24, 2023
...ers/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/lower_income_threshold.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...da/parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/basic_amount.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...da/parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/basic_amount.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...rs/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/higher_income_threshold.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...ers/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/lower_income_threshold.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/applicable_rate.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...rameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/additional_amount.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...rameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/additional_amount.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/applicable_rate.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...rs/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/higher_income_threshold.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...ers/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/lower_income_threshold.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...rameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/additional_amount.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
...parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/applicable_rate.yaml
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_credits.py
Outdated
Show resolved
Hide resolved
Snownow0w
reviewed
Jul 26, 2023
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount.py
Outdated
Show resolved
Hide resolved
...engine_canada/parameters/gov/provinces/ns/tax/income/credits/basic_personal_amount/base.yaml
Show resolved
Hide resolved
...meters/gov/provinces/ns/tax/income/credits/basic_personal_amount/additional_amount/base.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount.py
Show resolved
Hide resolved
…-canada into okeyiii/issue395
Fixes PolicyEngine#395 Add income threshold back, and use where as return
…ngine-canada into okeyiii/issue395
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount.py
Outdated
Show resolved
Hide resolved
…its/ns_basic_personal_amount.py
PavelMakarchuk
approved these changes
Sep 10, 2023
MaxGhenis
requested changes
Sep 29, 2023
...rovinces/ns/tax/income/credits/basic_personal_amount/additional_amount/income_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount.py
Outdated
Show resolved
Hide resolved
Fixes PolicyEngine#395 merge changes
…ngine-canada into okeyiii/issue395
Update the return value Fix PolicyEngine#395
income_threshold is not actually used, delete it. Fixes PolicyEngine#395
…-canada into okeyiii/issue395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #395