Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phylopic wrapper #169

Merged
merged 49 commits into from
Apr 25, 2023
Merged

Phylopic wrapper #169

merged 49 commits into from
Apr 25, 2023

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Apr 22, 2023

What this PR does

  • create a new component package called Phylopic, that is a wrapper on the phylopic API
  • add documentation showing how to use the silhouettes in practice -- see this link to see how

Linked issues

Release goals

  • Phylopic.jl v0.0.1 with bare-bones functionalities

Release outcomes

Closes #157

@github-actions
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Patch coverage: 35.95% and project coverage change: -1.00 ⚠️

Comparison is base (5571028) 54.27% compared to head (1eb5313) 53.27%.

❗ Current head 1eb5313 differs from pull request most recent head 5aa2547. Consider uploading reports for the commit 5aa2547 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   54.27%   53.27%   -1.00%     
==========================================
  Files          48       53       +5     
  Lines        1544     1633      +89     
==========================================
+ Hits          838      870      +32     
- Misses        706      763      +57     
Flag Coverage Δ
unittests 53.27% <35.95%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Phylopic/src/attribution.jl 0.00% <0.00%> (ø)
Phylopic/src/images.jl 0.00% <0.00%> (ø)
Phylopic/src/ping.jl 30.76% <30.76%> (ø)
Phylopic/src/autocomplete.jl 77.77% <77.77%> (ø)
Phylopic/src/imagesof.jl 80.76% <80.76%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tpoisot tpoisot marked this pull request as ready for review April 25, 2023 23:32
@tpoisot tpoisot merged commit 12d567c into main Apr 25, 2023
@tpoisot tpoisot deleted the feat/phylopic branch April 25, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants