Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created header for low level I/O helpers. Fix for ::posix_fallocate on Mac OSX #2354

Merged
merged 2 commits into from
Jun 22, 2018
Merged

Created header for low level I/O helpers. Fix for ::posix_fallocate on Mac OSX #2354

merged 2 commits into from
Jun 22, 2018

Conversation

rowanborder
Copy link
Contributor

Replacing uses of ::posix_fallocate with new function io::raw_fallocate to fix compilation on Mac OSX.

@taketwo
Copy link
Member

taketwo commented Jun 22, 2018

Thx. We overlooked substituting posix_fallocate calls for the new function. So I suppose this compiles of Mac OSX for you? I'll wait for CI results and merge.

@taketwo taketwo merged commit 6cae3f2 into PointCloudLibrary:master Jun 22, 2018
@de-vri-es
Copy link
Contributor

de-vri-es commented Jun 22, 2018

Heh, oops. Thanks for the fix! 👍

@SergioRAgostinho SergioRAgostinho changed the title Fix for ::posix_fallocate on Mac OSX (PR #2341) Created header for low level I/O helpers. Fix for ::posix_fallocate on Mac OSX Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants