Harmonize default representation in PCLVisualizer

[VictorLamoine]

All shapes are rendered as wire-frame by default; I see no reason why one of the addPlane should not follow that rule.

Reported by Silex: http://www.pcl-users.org/pcl-visualization-PCLVisualizer-addPlane-function-draws-only-boundary-of-the-plane-tp4036992p4037214.html

EDIT: as Sergey suggested; I switched them all to surface, for the line I see no change between wireframe/surface.

[taketwo]

I agree that both addPlane() functions should set the same representation. But I would argue that "surface" mode is more appropriate for a plane. I think we'll need more opinions to make a decision.

[VictorLamoine]

Adding them as surface is probably more convenient; here are the different shapes:
cube, cylinder, sphere, PolyData, plane, cone, line and circle.

For the circle, this is what is does: (surface on the left, wireframe on the right)

So the question is: Wireframe or surface?

[VictorLamoine]

Friendly pi(n)g 🐷 @jspricke
Is it ok to switch all shapes from wireframe to surface ?

[taketwo]

Victor, I'm not sure I understand the logic behind changing the default representation of all shapes. As far as I understand, the original complaint was only about different plane functions using different representations. Why do we need to change everything else?

[VictorLamoine]

The idea is to be consistent; either a shape should be added as wireframe or surface by default.
I don't think it's a good idea to add some shapes in wireframe and others in surface representation.

At the moment one version of the addPlane functions adds a plane in surface representation, while every other shapes are added in wireframe mode.

So we should change the addPlane function to wireframe or switch all the others to surface. I think its more logical to add all shapes in surface representation.

[taketwo]

Still don't get why we need consistency between different shapes. Planes are better off with surfaces, yes, but why everything else should be the same?

[VictorLamoine]

We don't need consistency, but it would be better.
Everything else should be the same because when the users adds a sphere, he probably expects a volume; not a wire frame.

[taketwo]

Ok, what about cubes? I never used it myself, but I would expect that people may use it to outline a detected object, in which case wireframe is more appropriate...

[jspricke]

+1 for switching all to surface.

[taketwo]

Ok, I'll merge then.

[VictorLamoine]

Ok, what about cubes? I never used it myself, but I would expect that people may use it to outline a detected object, in which case wireframe is more appropriate...

It really depends on the usage; I used the cube to model a real cube in my robot workspace for example.
And you can use a transparent cube to outline a detected object.

setShapeRenderingProperties is available for those who want to change the rendering anyway.