Feature Time to read #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gndx
requested changes
Apr 9, 2020
src/pages/index.js
Outdated
| @@ -1,6 +1,7 @@ | |||
| import React from "react" | |||
| import { Link, graphql } from "gatsby" | |||
|
|
|||
|
|
|||
src/templates/blog-post.js
Outdated
| @@ -7,17 +7,26 @@ import Layout from "../components/layout"; | |||
| import SEO from "../components/seo"; | |||
| import { rhythm } from "../utils/typography"; | |||
|
|
|||
| const readingTime = (text)=> { | |||
There was a problem hiding this comment.
Suggested change
| const readingTime = (text)=> { | |
| const readingTime = (text) => { |
src/templates/blog-post.js
Outdated
| const minutes = numOfWords / wordsPerMinute; | ||
| const readTime = Math.ceil(minutes); | ||
| return `Tiempo de lectura ${readTime} min`; | ||
| } |
There was a problem hiding this comment.
Esta función debe de estar en /utils/
src/templates/blog-post.js
Outdated
|
|
||
| return ( | ||
| <Layout location={location} title={siteTitle}> | ||
| <SEO | ||
| title={title} | ||
| description={description || post.excerpt} | ||
| description={description + timeToRead || post.excerpt} |
There was a problem hiding this comment.
timeToRead no es necesario en la Descripción del sitio. Utilizar las meta etiquetas para el SEO.
|
Ya quedaron los cambios @gndx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Te da el tiempo de lectura en minutos de los post de platziblog, tomando en cuenta que en un adulto en promedio lee 200 palabras por minutoi
INFORMATION
PR TYPE