Add jobid checking to preprocess #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZedThree
reviewed
Aug 19, 2024
ZedThree
approved these changes
Aug 19, 2024
I don't think so, that would affect individual datasets. There doesn't seem to be a way to hook into |
|
Good point... pity that users need to define all those variables to get it working but for now I think it's fine |
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
ZedThree
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
jobid1checking to the preprocess and separate out into new class that can be called from the code. Came about because of issue #9Did we want to make it the default option in
SDFEntrypointto avoid needing to callfrom sdf_xarray import SDFPreprocess?Fixes #9