Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix after login redeem process issue #1589

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

sunilsabatp
Copy link
Contributor

fix: -->1.when user tries to claim code using route /claim/gift/:code without login. it redirect user to login page then when login process gets complete then user reaches to redeem modal using the same route (i.e /claim/gift/:code) but redeem modal does not show any result of that code(i.e invalid code, already redeemed, successfully redeemed) .

2-->cross button of modal (change to cursor)

@vercel
Copy link

vercel bot commented Oct 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
planet-webapp ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 3:15PM (UTC)

@mariahosfeld
Copy link
Contributor

Functionality works for me.

@sagararyal
Copy link
Member

sagararyal commented Oct 20, 2022

@mariahosfeld
Copy link
Contributor

Functionality works for me.

@mariahosfeld
Copy link
Contributor

Both routes work within this PR.

Copy link
Contributor

@Shreyaschorge Shreyaschorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariahosfeld mariahosfeld merged commit eafd748 into develop Oct 21, 2022
@mariahosfeld mariahosfeld deleted the Fix/redeemCodeOldRoute_minorBugs branch October 21, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants