Apply one remapping per path #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code processed multiple remappings for a single path and then attempted to "dedup" nested remappings, whatever that means. The "dedup" did not work at all, for example with Foundry's template Counter project, Analyzer would look for the file "lib/forge-std/src/lib/ds-test/src/test.sol" which did not exist. And if you allow multiple remappings on a single path, you end up with "lib/lib/forge-std/src/lib/ds-test/src/test.sol", which also does not exist. This commit does one remapping rule per path and breaks out of the loop, which is the way remappings should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code processed multiple remappings for a single path and then attempted to "dedup" nested remappings, whatever that means.
The "dedup" did not work at all, for example with Foundry's template Counter project, Analyzer would look for the file "lib/forge-std/src/lib/ds-test/src/test.sol" which did not exist.
And if you allow multiple remappings on a single path, you end up with "lib/lib/forge-std/src/lib/ds-test/src/test.sol", which also does not exist.
This commit does one remapping rule per path and breaks out of the loop, which is the way remappings should work.