Reduce pipeline use-after-free errors #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really we need to nuke all this use after free cruft I added and replace it with a proper thread model and queue for incoming messages. That said, probably doesn't hurt to send this. |
Alextopher
approved these changes
Oct 7, 2024
|
Correct. I talked with Matt and will attempt to fix the issue at its root. It may take a while so why not just push this... Yolo. Basically, the UI adds to a list then the camera applies the changes in said list when it gets around to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always check to see if the pipeline has changed while we were grabbing the frame and if it was, skip the pipeline run.