-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks good to me :) We may want to change some details (e.g. do a reimplementation of the C++ Part) and we also need to register the newly implemented functions to docs
SEARCHSORTED_AVAILABLE = False | ||
|
||
|
||
class Interp1d(torch.autograd.Function): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at this repo, we may want to reimplement this part in PyTorch's Python interface (which shouldn't take so long, I'll maybe have a look this weekend).
We would prefer not to have external dependencies :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new torch.searchsorted function, we don't need the external dependency any more :)
CODEOWNERS
Outdated
/rising/transforms/kernel.py @mibaumgartner | ||
/rising/transforms/spatial.py @justusschock @mibaumgartner | ||
/rising/transforms/utility.py @justusschock @mibaumgartner | ||
/rising/transforms/painting.py @weningerleon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CODEOWNERS file is basically not for code ownership (name is a bit misleading), but for automated PR review requests. This means if you register yourself here as an owner, you probably will get automated requests to review PRs for these files.
The actual code ownership is handled based on commits and the associated accounts.
update to head
Co-authored-by: Paul <paul.weinmann@rwth-aachen.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mibaumgartner for review
Co-authored-by: Paul <paul.weinmann@rwth-aachen.de>
Short Description
What do you think of this proposition of the models genesis transforms? What kind of tests do you think are necessary?