V2 API Route #251

PhlexPlexico · 2023-06-12T22:17:26Z

This is going to be a bit of a longer WIP branch, but this has some sweeping changes that should make this compatible with the latest versions of get5. If there is an older version, it will still look for the G5WS plugin, however it is now no longer required as of Get5 0.14.

This is the feature list that needs to be incorporated for the API that holds the connection to the game server:

Series Flow

Map Flow

Misc

Documentation
Cleanup of duplicate functionality
Docker build/tagging
Dockerfile cleanup to ensure it can still actually launch within a docker conatiner
Remote Backups
Remote Demo Uploads

There is still a few other changes that need to be made, such as extending new features for match configs (like more refined veto selection and choices) that may make it into this PR, but it is still undecided.

This update will also attempt to start converting some of this project into TypeScript, as there has been quite a few issues I've ran into with typing.

Begin extra stats documentation.

…Death?

Update database to use actual steam IDs and whatnot.

Remove extra player stats from legacy api since they were not finished. Update serverrcon.js - Breakout packet handling to its own function. - Check version for 0.14 or higher. TBD if we can use 0.13. - Set log and backup URLs and keys to use API keys. - Fix formatting Update prodrun to point to dist for compiled js.

Everything mainly in src now, types in types, services (like db and various service calls to database) in services, etc. Bring in start of finding API key and match id. These will be checked before being sent off to different cases.

Removed OnSeriesInit as it is not needed. Forfeits are not implemented, but may not be needed right now, can check on round end instead and update as needed.

Finish map and series finishing. Start on pick/ban updates.

Update mapupdate to not use team ids from database. Update various TS calls to user lowercase identifiers.

Adjust imports on map flow service. Update api.ts to include new cases for the series flow.

Include OnPlayerDeath and OnMatchPaused and OnMatchUnpaused. Update serverrcon to include demo, logs, and backups. Update match creation to get version number if we select a server.

Since these are game specific, we will not create public API calls for this.

Update github actions to deploy next and version tag. Begin work on demo uploads.

Update package json version.

Update leaderboard swagger to add success option. Consider moving components to their own JS files for easier typing and location.

Include more docs for the MapFlowService.

Fix match registering version numbers for get5.

This should fix the bug of multiple matches being generated with the same server. Only update game server if the server is alive and available as well.

PhlexPlexico · 2023-06-18T18:50:07Z

Can confirm basic match creation is working as intended while making older versions still compatible with the old G5WS plugin.

PhlexPlexico · 2023-06-18T18:51:15Z

And also https://phlex.avidgamers.me is now pointing to the new instance. So if anyone out there wants to test, that is available!

PhlexPlexico · 2023-06-20T18:12:29Z

One or two possible issues that may have to be rectified after review and initial testing

Team Logos not transferring over, need to do this on series init somehow. However, team logos were already fairly broken to begin with.
backups and demos may not save in the public folder, but under src/public. Will need to verify that this isn't the case.

…release. Update README.

PhlexPlexico · 2023-06-23T18:10:00Z

I think aside from team logos, this should be good to merge now. Even without team logos, this is now working as intended I believe.

Bunker56 · 2023-06-24T14:34:02Z

Docker 24.0.2
Get5 0.14.7 (default cfg)
[get5.smx] Event HTTP request failed due to a network or configuration error. Make sure you have enclosed your event URL in quotes.
do I need additional plugin settings or did I fail to see something?

Bunker56 · 2023-06-24T14:35:28Z

Sorry!.. I will unsubscribe in more detail later, while there is no possibility...

PhlexPlexico · 2023-06-24T14:45:23Z

So did you figure it out? You could also check the API logs and see if there's any error on its end.

Also if there is an error, please create an issue :)

Bunker56 · 2023-06-24T16:06:00Z

one more thing confuses me, there is a get5_remote_log_url parameter in the plugin documentation, but it is not in the config file. Could it be the case?

PhlexPlexico · 2023-06-24T16:09:12Z

G5API/src/utility/serverrcon.js

Lines 208 to 212 in c92bfb7

    
           "get5_remote_log_url ".concat( 
        
             apiString.endsWith("/") 
        
               ? apiString.concat("v2") 
        
               : apiString.concat("/v2") 
        
           )

See here, it's set during the match setup, as well as a handful of other url settings for get5. The config file does not set these as they need to be set via rcon.

PhlexPlexico · 2023-06-24T16:11:44Z

And please, if you need any more questions answered, feel free to create a new Discussion :)

Bunker56 · 2023-06-24T16:13:42Z

this is a piece of the log with an error that was in the previous API, the API logs are fine, there are no errors
BNK#3: !r
L 06/24/2023 - 18:27:12: "BNK#3<3><STEAM_1:1:537158178>" say "!r"
src/common/httpclient.cpp (808) : pHost && *pHost
src/common/httpclient.cpp (808) : pHost && *pHost
L 06/24/2023 - 18:27:12: [get5.smx] Event HTTP request failed due to a network or configuration error. Make sure you have enclosed your event URL in quotes.
BNK#1: !r
L 06/24/2023 - 18:27:26: "BNK#1<6><STEAM_1:1:537225542>" say "!r"
src/common/httpclient.cpp (808) : pHost && *pHost
src/common/httpclient.cpp (808) : pHost && *pHost
L 06/24/2023 - 18:27:26: [get5.smx] Event HTTP request failed due to a network or configuration error. Make sure you have enclosed your event URL in quotes.

PhlexPlexico added 18 commits June 7, 2023 19:25

Bring in new database changes for extra player stats.

c004821

Fix Dockerfile to avoid potential COPY errors.

793d421

Begin refactor for extra stats as playerstats is too large of a file.

4616656

Update DB layout.

a58f3e3

Begin extra stats documentation.

Include new extra stats route and non-live gets.

b77d37f

Finish CRUD operations. Move onto new API implementation for OnPlayer…

958bbd6

…Death?

Bring in initial start of call for plugin.

7531f89

Update database to use actual steam IDs and whatnot.

Implement additional stat carry over. Needs to be tested.

37b3598

Update deps and include types from docs.

8e8f3b7

Continue on rewiring tests.

87b3791

Tests working, application not.

03d3c5a

Tests passing and app launching!

8ad9417

OnSeriesResult implemented.

0aa4514

Removed OnSeriesInit as it is not needed. Forfeits are not implemented, but may not be needed right now, can check on round end instead and update as needed.

Fix up some comments.

da85a66

Finish map and series finishing. Start on pick/ban updates.

Bring in team ID in the match configs since it's supported.

4403e37

Update mapupdate to not use team ids from database. Update various TS calls to user lowercase identifiers.

Veto updates and side selection complete.

8606bc1

PhlexPlexico marked this pull request as draft June 12, 2023 22:17

PhlexPlexico added the enhancement New feature or request label Jun 12, 2023

PhlexPlexico linked an issue Jun 12, 2023 that may be closed by this pull request

[Request] V2 API #249

Closed

10 tasks

PhlexPlexico added 3 commits June 12, 2023 16:23

Properly tag releases on push with version number as well.

cd4c5a4

Finish series flow service.

62584fc

Adjust imports on map flow service. Update api.ts to include new cases for the series flow.

OnGoingLive implemented.

99d370c

PhlexPlexico force-pushed the v2-api branch from f375626 to 99d370c Compare June 14, 2023 01:49

PhlexPlexico added 4 commits June 14, 2023 12:10

Update the player stat extras table.

7f111ba

Include OnPlayerDeath and OnMatchPaused and OnMatchUnpaused. Update serverrcon to include demo, logs, and backups. Update match creation to get version number if we select a server.

Include bomb plant and defuse events from game server to API calls.

72e205e

Since these are game specific, we will not create public API calls for this.

Finish map and series flows.

cffb4e0

Update github actions to deploy next and version tag. Begin work on demo uploads.

Change docker tags to use latest and next for now.

2394b55

PhlexPlexico force-pushed the v2-api branch from 713728e to 78e069d Compare June 16, 2023 18:14

PhlexPlexico force-pushed the v2-api branch 3 times, most recently from 3e2bccf to ccc7e40 Compare June 16, 2023 18:26

Docker debugging.

86087a9

Update package json version.

PhlexPlexico force-pushed the v2-api branch from ccc7e40 to 86087a9 Compare June 16, 2023 20:02

PhlexPlexico added 3 commits June 16, 2023 21:46

Add in demo API.

739ff77

Update leaderboard swagger to add success option. Consider moving components to their own JS files for easier typing and location.

Bring in remote backup API calls.

dc3a025

Update JSDocs.

ed518b9

Include more docs for the MapFlowService.

PhlexPlexico marked this pull request as ready for review June 17, 2023 06:20

PhlexPlexico added the pending feedback When awaiting testing from users. label Jun 18, 2023

PhlexPlexico added 3 commits June 18, 2023 11:27

Fix error with incomplete packets call.

393d3f2

Fix server rcon values not being respected in strings.

dd63ad7

Fix match registering version numbers for get5.

Delete match from database if we fail to load on the server.

0ffd26c

This should fix the bug of multiple matches being generated with the same server. Only update game server if the server is alive and available as well.

Update README.md

9e205a5

Update workflow to push next on any branch but version only on final …

66236b8

…release. Update README.

PhlexPlexico merged commit c92bfb7 into master Jun 23, 2023
1 check passed

PhlexPlexico deleted the v2-api branch June 23, 2023 18:10

PhlexPlexico mentioned this pull request Jun 24, 2023

URLs not being set properly #252

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V2 API Route #251

V2 API Route #251

PhlexPlexico commented Jun 12, 2023 •

edited

Loading

PhlexPlexico commented Jun 18, 2023

PhlexPlexico commented Jun 18, 2023

PhlexPlexico commented Jun 20, 2023

PhlexPlexico commented Jun 23, 2023

Bunker56 commented Jun 24, 2023 •

edited

Loading

Bunker56 commented Jun 24, 2023 •

edited

Loading

PhlexPlexico commented Jun 24, 2023 •

edited

Loading

Bunker56 commented Jun 24, 2023

PhlexPlexico commented Jun 24, 2023 •

edited

Loading

PhlexPlexico commented Jun 24, 2023

Bunker56 commented Jun 24, 2023 •

edited

Loading

V2 API Route #251

V2 API Route #251

Conversation

PhlexPlexico commented Jun 12, 2023 • edited Loading

Series Flow

Map Flow

Misc

PhlexPlexico commented Jun 18, 2023

PhlexPlexico commented Jun 18, 2023

PhlexPlexico commented Jun 20, 2023

PhlexPlexico commented Jun 23, 2023

Bunker56 commented Jun 24, 2023 • edited Loading

Bunker56 commented Jun 24, 2023 • edited Loading

PhlexPlexico commented Jun 24, 2023 • edited Loading

Bunker56 commented Jun 24, 2023

PhlexPlexico commented Jun 24, 2023 • edited Loading

PhlexPlexico commented Jun 24, 2023

Bunker56 commented Jun 24, 2023 • edited Loading

PhlexPlexico commented Jun 12, 2023 •

edited

Loading

Bunker56 commented Jun 24, 2023 •

edited

Loading

Bunker56 commented Jun 24, 2023 •

edited

Loading

PhlexPlexico commented Jun 24, 2023 •

edited

Loading

PhlexPlexico commented Jun 24, 2023 •

edited

Loading

Bunker56 commented Jun 24, 2023 •

edited

Loading