Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to benchmark pull requests #6274

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rashidnhm
Copy link
Contributor

Context: Add ability to benchmark a pull request

Description of the Change:
This pull request adds the ability to benchmark a PR.

When a user with either admin or maintain permissions comments /benchmark on a pull request, this workflow will trigger a webhook to benchmarks repo with sufficient details to benchmark the PR, it is then up to the benchmarks action to report back with results.

Once the webhook is sent, a 👍 reaction is added to the comment to indicate it was successful.

Benefits:
New feature.

Possible Drawbacks:
This is an MVP product, we may want to iterate on this to add further information or functionality. However, the current state is sufficient for the basic needs of benchmarking.

Related GitHub Issues:
None. sc-73314

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (5f4169a) to head (98e31ff).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6274      +/-   ##
==========================================
- Coverage   99.63%   99.58%   -0.06%     
==========================================
  Files         445      443       -2     
  Lines       42433    42230     -203     
==========================================
- Hits        42278    42053     -225     
- Misses        155      177      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants