Support the generalization of basis state preparation and the facade legacy device for MPI LGPU #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
===========================================
- Coverage 91.77% 81.50% -10.28%
===========================================
Files 114 17 -97
Lines 18254 1946 -16308
===========================================
- Hits 16752 1586 -15166
+ Misses 1502 360 -1142 ☔ View full report in Codecov by Sentry. |
multiphaseCFD
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Thanks @maliasadi ! Don't forget to add an entry in the changlog
|
@multiphaseCFD there are more things to fix in latest/latest 😬 I'll update the changelog right after getting latest/latest 🟢 |
maliasadi
changed the title
vincentmr
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
LGTM, thanks @maliasadi . Do we want to run MPI tests before merging though? Or have you already run the workflows manually?
|
@vincentmr I've run them manually! But let's trigger them here too 👍 |
maliasadi
added
the
ci:use-multi-gpu-runner
multiphaseCFD
approved these changes
Aug 22, 2024
multiphaseCFD
pushed a commit
that referenced
this pull request
Sep 8, 2024
…legacy device for MPI LGPU (#864) ### Before submitting Please complete the following checklist when submitting a PR: - [x] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [x] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [x] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** - PR PennyLaneAI/pennylane#6021 removed code duplication for `BasisEmbedding` and `BasisState`. As the result `BasisState` no longer decomposes to `BasisStatePreparation`. This PR updates Python unit tests to support this generalization of basis state preparation. - PR PennyLaneAI/pennylane#6046 added a facade wrapper class for "legacy" devices. This PR is a follow up to PR #839 updating Multi-GPU LGPU device and tests. **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
PR Upgrade and generalise basis state preparation pennylane#6021 removed code duplication for
BasisEmbeddingandBasisState. As the resultBasisStateno longer decomposes toBasisStatePreparation. This PR updates Python unit tests to support this generalization of basis state preparation.PR Wrapping of legacy device automatically in various device creation/qnode/execute functions pennylane#6046 added a facade wrapper class for "legacy" devices. This PR is a follow up to PR Update generate_samples in LK and LGPU to support qml.measurements.Shots #839 updating Multi-GPU LGPU device and tests.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-71917]