fix: BufferSourceConverter.toArrayBuffer with Node.js Buffer slice #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using PKI.js in Node.js v20 I ran into bugs where
BufferSourceConverter.toArrayBuffer
of a slice would return a copy of its original, larger, buffer. Likely the library was calling the deprecatedBuffer.prototype.slice
where it should have calledBuffer.prototype.subarray
instead. Currently, pvtsutils does not handle such a Buffer slice view correctly. This change fixes that.