Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Pane component compatible with StrictMode #810

Merged
merged 8 commits into from
Jan 30, 2021
Merged

Make Pane component compatible with StrictMode #810

merged 8 commits into from
Jan 30, 2021

Commits on Dec 14, 2020

  1. Add failing test: rendering Pane in strict mode

    @zmbc
    zmbc committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    938dc8d View commit details
    Browse the repository at this point in the history

  2. Complete and lint tests

    @zmbc
    zmbc committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    ad63c1f View commit details
    Browse the repository at this point in the history

  3. Handle side effect with useEffect instead of useMemo

    @zmbc
    zmbc committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    2db074a View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary "Omit"

    @zmbc
    zmbc committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    b59970e View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Remove nameless panes

    @zmbc
    zmbc committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    b45e4a6 View commit details
    Browse the repository at this point in the history

  2. Make newContext update with context

    @zmbc
    zmbc committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    84ad6ed View commit details
    Browse the repository at this point in the history

  3. Test nested panes, unmounting and remounting

    @zmbc
    zmbc committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    0f3d929 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. Merge branch 'master' of https://github.com/PaulLeCam/react-leaflet 

    # Conflicts:
#	packages/react-leaflet/src/Pane.tsx
    @zmbc
    zmbc committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    261bef9 View commit details
    Browse the repository at this point in the history