utils/pick should catch falsy values #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulLeCam
requested changes
Dec 13, 2019
src/utils/pick.js
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| export default function pick(object: Object, keys: Array<string>): Object { | |||
| return keys.reduce((obj, key) => { | |||
| if (object[key]) { | |||
| if (object[key] !== undefined) { | |||
There was a problem hiding this comment.
Could you replace this by typeof object[key] !== 'undefined' please?
There was a problem hiding this comment.
Sure thing, good suggestion! 88db6a5
|
Thank you for being so responsive! We've already pulled the new release into production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating dynamic
Pathoptions, only truthy values are picked out of props to be updated. Path options can have valid falsy values, likefillOpacity: 0orbubblingMouseEvents: false. It is possible to initialize a dynamic property to a falsy value, but after changing it to a truthy one, it cannot be changed back. This PR changesutils/pick.jsso that it will pick any value that isn't=== undefined.