Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a geojson popup example #608

Merged
merged 1 commit into from
Aug 10, 2019
Merged

Conversation

hackleman
Copy link
Contributor

This is my first pull request so hopefully I am setting things up correctly. The postalcode geojson file is 50KB, I am not sure the best practices for commiting files like that (or whether it should even be in assets).

@PaulLeCam
Copy link
Owner

Thanks for your PR!
Could you please lower the size of the added JSON file and make sure the issues raised in CI are fixed?
Thanks!

@hackleman
Copy link
Contributor Author

Thank you for the opportunity! I made some small changes to pass the Travis CI checks and have a new geojson file ~ 3 - 4 KB

@hackleman hackleman force-pushed the geojson-example branch 2 times, most recently from 833bab8 to 91b44c6 Compare August 9, 2019 16:03
@PaulLeCam PaulLeCam merged commit 1e6fc9e into PaulLeCam:master Aug 10, 2019
@PaulLeCam
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants