Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Passes to only always, never or average crit chance #8270

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Aug 30, 2024

This is mostly a background change for a minor performance boost and to change what is displayed on the calcs page

This is mostly for something like plume of pursuit, which has an 80% less damage multiplier for non crits, but for the hits you care about it will always be a crit, this also will show inquisitors inevitable judgement ignore res instead of pen if your guaranteed to crit.

I have been sitting on this for a while and couldnt find any issues on any builds I tested, but it likely needs to be tested on more builds incase there is an issue. This also sets the crit skillCond as late as it can to prevent other issues, so that it doesnt impact any calculations, and only does it if its certain it will apply (100% chance), this could be changed to show in the average case (eg if crit chance is >= 50%) as its after all relevant calculations are done, but decided to be conservative

@LocalIdentity LocalIdentity added the technical Hidden from release notes label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Hidden from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants