Fix “MAX” effect ruthless calculation #8214
Open
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: when choosing max effect mode for ruthless calculation the damage is less than with average. This prevents player from understanding the bleed damage from ruthless hit, which basically is indifferent from attack speed Fix: Remove the unnecessary dpsMultiplier
|
This should likely be done similar to the repeats config, where you want a "max" and an "all hits use max", where max still has the dps multiplier, but the other one doesnt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect calculation of ruthless “MAX” effect.
Description of the problem being solved:
Issue: when choosing max effect mode for ruthless calculation the damage is less than with average. This prevents player from understanding the bleed damage from ruthless hit, which basically is indifferent from attack speed
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/R3766WkE8XHi
Before screenshot:
After screenshot: