Curses multiList #8203
Curses multiList #8203
Conversation
|
Update, decided to add some of the improvements in to this PR, as its small and related enough that it shouldnt make it much harder to review Silence doesnt work, it has an invalid name so doesnt showup on the list, if you give it a name to showup then the disable skills doesnt work, this is likely fine as people likely dont intend to want to build around it, so configuring it on "all curses" can be anoying |
src/Classes/ConfigTab.lua
Outdated
| t_insert(control.varControlList[1], dropDownControl) | ||
| local extraTypesExtraHeight = 0 | ||
| for j, varExtra in ipairs(varData.extraTypes or {}) do | ||
| if varExtra[1] == "integer" then |
There was a problem hiding this comment.
I think we use "count" everywhere else so using it here as well would make things more consistent.
There was a problem hiding this comment.
Integer is a type, yeah I can swap it to count, most things should use count instead anyway and fixes the other issue with negative numbers
src/Classes/ConfigTab.lua
Outdated
| local extraTypesExtraHeight = 0 | ||
| for j, varExtra in ipairs(varData.extraTypes or {}) do | ||
| if varExtra[1] == "integer" then | ||
| local editControl = new("EditControl", {"TOPLEFT",dropDownControl,"TOPLEFT"}, 225, 0, 90, 18, "", nil, "^%-%d", 7, function(buf, placeholder) |
There was a problem hiding this comment.
"^%-%d" allows for negative numbers which may not make sense in all contexts (curse levels). Would it make sense to make the filter a parameter and set it for each multiList individually?
Regisle
force-pushed
the
CursesMultiList
branch
from
6124c4f
to
22e537b
Compare
built ontop of #8200 (so merge that one first)
Reworks the curses section to use a multiList, I have other improvements planned for a future PR, but those are mostly revolved around making a proper list or other self curse improvements unrelated to config tab