Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Armour and ES breakdowns for "100% increased..." Armour and ES Mastery #7387

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Mar 16, 2024

Fixes #7386

Description of the problem being solved:

Update breakdowns to show the 100% increased Armour and Energy Shield on Body Armour from the Armour and Energy Shield Mastery.

Steps taken to verify a working solution:

  • Validate breakdown of armour equals total armour
  • Validate breakdown of energy shield equals total energy shield

Link to a build that showcases this PR:

https://pobb.in/ROa3CR-0WuiJ

Before screenshot:

image

image

After screenshot:

image

image

@Peechey Peechey added the bug: calculation Numerical differences label Mar 16, 2024
@LocalIdentity LocalIdentity merged commit 333e380 into PathOfBuildingCommunity:dev Mar 22, 2024
2 checks passed
@Peechey Peechey deleted the fix/breakdown_ArmourESMastery branch March 27, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Armour and ES Mastery not reflecting properly in Total Armour and ES Breakdowns in Calcs Tab
2 participants