Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enemy dot skills #6809

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Oct 12, 2023

Built on #5754 and #6803 those must be merged first
only the last 7 commits are unique atm

Adds support for enemy damage type of damage over time, this makes the configuration options apply to damage over time instead, and added a new section for it in calcs tab, as well as added shaper beam as a damage over time boss skill
image

Theres still a few things I wish to do, improve the breakdowns and implement total net regen taking enemy degens and recoup/petrified blood degens into account

I would also like to add more boss degens, Sirus Storm and Cortex ground degen are the 2 that comes to mind at the moment

Sirus storm doesnt seem to be a skill and is a buff atlas_orion_death_zone / atlas_orion_death_zone_core so unsure how to export it correctly, and Have not looked at cortex yet

edit: added cortex degen, and improved the breakdowns, at the moment theres no way to have an enemy degen and recoup at the same time, so leaving this for a future PR that adds enemy ailments or multi type skills or recoup based on self damage, IMO only thing left to check is there are no more crashes/issues with the new damage type and then add sirus storm degen

@Paliak Paliak added the enhancement New feature, calculation, or mod label Oct 27, 2023
@Regisle Regisle marked this pull request as ready for review December 5, 2023 07:25
@Regisle
Copy link
Member Author

Regisle commented Dec 5, 2023

Siruis storm still missing but otherwise should be good to merge, the storm can be added later

@LocalIdentity LocalIdentity merged commit c5e22ac into PathOfBuildingCommunity:dev Jul 22, 2024
2 checks passed
@Regisle Regisle deleted the EnemyDotSkills branch July 22, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants