Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

places: Add Frost folders #3547

Closed
wants to merge 1 commit into from

Conversation

mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Sep 3, 2023

Signed-off-by: Zephyr Lykos git@mochaa.ws

Signed-off-by: Zephyr Lykos <git@mochaa.ws>
@SmartFinn
Copy link
Member

Thanks. Unfortunately, I decided to stop adding the new folders colors, to keep papirus-folders script usable. Maybe I create a utility that allows to add the user's colors.

See #3520 (comment) for some details.

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 3, 2023

The problem with the original nordic folders is that they're actually not in the Nord color scheme. If you wish you could replace them with the colors in this PR.

@SmartFinn
Copy link
Member

@mochaaP thank you for pointing to that. What do you prefer more, rename the Frost folder to Nordic, or remove Nordic folders with adding the Frost?

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 3, 2023

I'm okay with both options.

If you need a correctly colored Nordic theme, use this:

       	[nordic]="    #88c0d0 #8fbcbb #3b4253 #eceff4"

(there is still some problem though - #8fbcbb is semantically not a dimmed variant of #88c0d0, but #88c0d0 should be the primary accent according to the docs)

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 3, 2023

image

Preview of the corrected nordic color.

@SmartFinn
Copy link
Member

There is too much of the blue folder colors. I want to keep only one.

@SmartFinn
Copy link
Member

Do you agree if I only change colors for nordic folder color?

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 3, 2023

No worries! It's your project, so it's up to you 😉.

@SmartFinn
Copy link
Member

@mochaaP I asked you because you are a user of these folders 😉

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 3, 2023

I hope you can add them, so I don't have to maintain a downstream fork just for folder colors in my project. Thanks!

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 9, 2023

Experimented with the "nordic" color last week on my main desktop, it just feels odd for me. Again, this is a personal preference, but if we have to choose one I'd like the new "frost" one. If anyone likes the original "nordic" palette, please leave your feedback! :)

@SmartFinn
Copy link
Member

Do you mean the current nordic folders, or colors for nordic that you suggested above?

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 9, 2023

Actually both of them. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants