Add icon for nvtop #3513
Merged
Add icon for nvtop #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I see this icon differently, a bit more close to the upstream one. What do you think?
|
|
Yeeeeeah..... Yours is definitely better. I also had a thought about giving it a black background, like in |
|
Cool. Could you adapt this mockup to other sizes? |
|
OK, I'll try |
|
@SmartFinn Redid the icon and updated the description. I decided against putting everything close like in your mockup and gave objects a bit more room to breathe. How does this look? |
|
@morganist It looks great. Thanks! Maybe, I'll change the outline on 16px icon equal to 1px, instead of 2px. The big dark outline does not fit in the design. |
* Add missing light outline * Increase radius of rounded corners for inner rectangles * Replace path objects with rect+stroke for 22/24/48px icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3510
Resembles the original icon but simplified
Original icon: