Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some more flathub symlinks #2007 #3475

Merged
merged 2 commits into from
Jul 12, 2023
Merged

add some more flathub symlinks #2007 #3475

merged 2 commits into from
Jul 12, 2023

Conversation

badlydrawnface
Copy link
Contributor

@badlydrawnface badlydrawnface commented Jul 11, 2023

added symlinks for:
cc.arduino.IDE2
com.github.Matoking.protontricks
ru.yandex.Browser
xyz.diamondb.gtkcord4

@SmartFinn
Copy link
Member

Thanks for the contribution. I see an issue with this PR: 3 of 4 icons for these packages have differed color and/or shape. I don't think that is the right way. Could you remove the following symlinks from the PR:
cc.arduino.IDE2
com.github.Matoking.protontricks
xyz.diamondb.gtkcord4

@badlydrawnface
Copy link
Contributor Author

badlydrawnface commented Jul 12, 2023

I can remove arduino2's symlink, however on a local protontricks installation, the desktop file looks for wine's icon, and for the flatpak version, it uses Breeze's Wine icon. In addition, the non-flatpak gtkcord is already symlinked to discord's icon on Papirus.

Screenshot_20230712_020131
Screenshot_20230712_015825
image

@SmartFinn
Copy link
Member

@badlydrawnface OK. Keep com.github.Matoking.protontricks and xyz.diamondb.gtkcord4 symlinks in the PR. It will need to add icons for them later.

@SmartFinn SmartFinn merged commit 0b7522f into PapirusDevelopmentTeam:master Jul 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants