Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change obsidian icon to new updated icon #3444

Merged
merged 18 commits into from
Jun 2, 2023
Merged

Change obsidian icon to new updated icon #3444

merged 18 commits into from
Jun 2, 2023

Conversation

VPS07
Copy link
Contributor

@VPS07 VPS07 commented Jun 2, 2023

No description provided.

@SmartFinn
Copy link
Member

At first sight, there are few issues:

  1. The object on the icon is bigger than should be. See https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/tools/work/README.md#basic-concepts
  2. The icons should not use gradients. It's out of Papirus style.

@VPS07
Copy link
Contributor Author

VPS07 commented Jun 2, 2023

This is the official icon of obsidian. Today they changed their icon to new one.
https://obsidian.md/blog/new-obsidian-icon/
They have launched some variations of icons. In their main icon they have used the gradients and object is bigger than their previous icon.

@VPS07
Copy link
Contributor Author

VPS07 commented Jun 2, 2023

I have made few changes from myself to icon and removed the complete gradient
https://imgur.com/RjG0Del
Should i use this icon?

@SmartFinn
Copy link
Member

SmartFinn commented Jun 2, 2023 •
edited
Loading

@VPS07 these outlines are out Papirus style too:

image

It's too hard to make it pixel perfect.

@SmartFinn
Copy link
Member

@VPS07 looks great! Please make it pixel perfect as close as you can.

@SmartFinn
Copy link
Member

@VPS07 Please do not upload any changes, I already start fixing the current issues.

@VPS07
Copy link
Contributor Author

VPS07 commented Jun 2, 2023

Sorry but I have not seen your message. I have pushed some changes to optimize the icons

@SmartFinn SmartFinn merged commit 61f0f50 into PapirusDevelopmentTeam:master Jun 2, 2023
SmartFinn added a commit that referenced this pull request Jun 2, 2023
@SmartFinn
Fix Obsidian icon #3444
0dac817 
1. Fix edge pixelation
2. Fix blurring edges
3. Add shadows and highlights
@SmartFinn SmartFinn mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VPS07 @SmartFinn