Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlinks for new RSS Guard app ids #3352

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

guihkx
Copy link
Contributor

@guihkx guihkx commented Dec 9, 2022

Starting from version 4.3.0 (probably), RSS Guard will have two separate app ids:

  • io.github.martinrotter.rssguard (official build, with built-in web browser support)
  • io.github.martinrotter.rssguardlite (official build, no built-in web browser support)

These two new ids had to be created from scratch, instead of just re-using the previous one (com.github.rssguard) to create the 'lite' variant.

That's because the old id is considered invalid by today's Flatpak naming standards, so it would not be possible to re-use it.

Upstream PR: martinrotter/rssguard#836

Starting from version 4.3.0 (probably), RSS Guard will have two separate app ids:

- io.github.martinrotter.rssguard (official build, with built-in web browser support)
- io.github.martinrotter.rssguardlite (official build, no built-in web browser support)

These two new ids had to be created from scratch, instead of just re-using the previous one (com.github.rssguard) to create the 'lite' variant.
That's because the old id is considered invalid by today's Flatpak naming standards, so it would not be possible to re-use it.
@SmartFinn
Copy link
Member

Thanks. Please let me know when upstream PR will be merged.

@guihkx
Copy link
Contributor Author

guihkx commented Dec 9, 2022

Will do!

FWIW, io.github.martinrotter.rssguard is already being used in 4.2.6 (scheduled for release in a few days), however io.github.martinrotter.rssguardlite was postponed to 4.3.0 because it changes quite a lot of things.

@guihkx
Copy link
Contributor Author

guihkx commented Dec 22, 2022

Hi, my PR was accepted and now both app ids are in use in version 4.2.7.

Thanks!

@SmartFinn SmartFinn merged commit 2a42920 into PapirusDevelopmentTeam:master Dec 22, 2022
@guihkx guihkx deleted the rssguard-rename branch December 22, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants