Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th No.8】为 Paddle 新增FeatureAlphaDropout API #890

Closed
wants to merge 1 commit into from

Conversation

MagnetoWang
Copy link

add rfcs

Copy link

paddle-bot bot commented May 5, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@CLAassistant
Copy link

CLAassistant commented May 5, 2024

CLA assistant check
All committers have signed the CLA.

@MagnetoWang MagnetoWang changed the title 【Hackathon 6th Article No.8】为 Paddle 新增FeatureAlphaDropout API 【Hackathon 6th No.8】为 Paddle 新增FeatureAlphaDropout API May 5, 2024

参数表:

- input: (Tensor) 输入的 tensor。维度至少大于2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align with other API, suggest use 'x'.

# 四、对比分析

对比 PyTorch :
- PyTorch 有 cpp 和 cuda 两种实现方法
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the different?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

准确点是:cpu和gpu两种写法


# 六、测试和验收的考量

- 覆盖 CPU 测试场景,暂不考虑GPU场景
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why CPU only?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

分三期做吧,一期是python接口实现,稳定后,二期,出于性能优化,实现一版cpp算子,三期,再优化实现一版cuda的gpu算子

# 六、测试和验收的考量

- 覆盖 CPU 测试场景,暂不考虑GPU场景
- 支持各种Tensor精度,FP32、FP64 等(待验证)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should support more date types

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@luotao1 luotao1 closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants