post the meeting agenda of the 1st meeting of PPWG-HAT #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzhang533
reviewed
Dec 12, 2023
working_groups/02_HA/README.md
Outdated
|
|
||
| # 2）基于硬件适配的代码合入机制 | ||
|
|
||
| 飞桨基于飞桨框架（https://github.com/PaddlePaddle/Paddle）和飞桨自定义硬件接入（https://github.com/PaddlePaddle/PaddleCustomDevice ）两个代码仓库，与硬件厂商展开代码合入与持续集成CI建设。对于适配合作的硬件厂商，飞桨都开放代码仓库，愿意在不影响框架迭代发展的情况下，接受各硬件厂商的适配代码。 |
There was a problem hiding this comment.
please correct markdown format.
working_groups/02_HA/README.md
Outdated
|
|
||
| # 2）基于硬件适配的代码合入机制 | ||
|
|
||
| 飞桨基于飞桨框架（https://github.com/PaddlePaddle/Paddle）和飞桨自定义硬件接入（https://github.com/PaddlePaddle/PaddleCustomDevice ）两个代码仓库，与硬件厂商展开代码合入与持续集成CI建设。对于适配合作的硬件厂商，飞桨都开放代码仓库，愿意在不影响框架迭代发展的情况下，接受各硬件厂商的适配代码。 |
There was a problem hiding this comment.
对于适配合作的硬件厂商，飞桨都开放代码仓库，
这句话描述有种隐含的意思：对未合作的厂商，不开放代码仓库。实际情况是，作为开源项目，飞桨的代码仓库是对所有人都开放的。
愿意在不影响框架迭代发展的情况下，接受各硬件厂商的适配代码。
这句话的描述不恰当。
working_groups/02_HA/README.md
Outdated
|
|
||
| # 3）持续集成建设（CI）机制 | ||
|
|
||
| 在持续集成CI建设方面，飞桨对所有厂商保持公平态度，不设置门槛，欢迎有技术合作的硬件厂商建设持续集成CI流水线。 |
There was a problem hiding this comment.
hmm...
作为开源项目，共建飞桨的协作是 "collective efforts"，请更新这段话。
|
cc: @qili93 @nizhaoqiao |
update the README to resolved the issue raised by reviewers
delete unnecessary blanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the title