update HMC API #541
update HMC API #541
Conversation
|
|
ppsci/probability/hmc.py
Outdated
| from paddle.distribution import Normal | ||
| from paddle.distribution import Uniform | ||
|
|
||
| from ppsci.utils import set_random_seed |
There was a problem hiding this comment.
==> from ppsci import utils
ppsci/probability/hmc.py
Outdated
| from paddle.distribution import Normal | ||
| from paddle.distribution import Uniform |
There was a problem hiding this comment.
==> from paddle import distribution
ppsci/probability/hmc.py
Outdated
| @@ -12,95 +12,149 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| from collections import OrderedDict | |||
There was a problem hiding this comment.
python>=3.7 的dict应该是默认与添加顺序保持一致的，可以不使用这个OrderedDict
ppsci/probability/hmc.py
Outdated
| """ | ||
|
|
||
| def __init__(self, tensor: paddle.Tensor): | ||
| self.tensor = tensor | ||
| def __init__(self, tensor_dict: OrderedDict): |
There was a problem hiding this comment.
==> Dict[str, paddle.Tensor]
| num_warmup_steps: int = 0, | ||
| random_seed: int = 1024, |
There was a problem hiding this comment.
docstring添加一下这两个参数
ppsci/probability/hmc.py
Outdated
| num_warmup_steps: int = 0, | ||
| random_seed: int = 1024, | ||
| ): | ||
| self.dist = distribution_fn |
There was a problem hiding this comment.
==> self.distribution_fn
ppsci/probability/hmc.py
Outdated
| q0_nlp = -self.dist(**q0) | ||
| q1_nlp = -self.dist(**q1) |
There was a problem hiding this comment.
这个是之前pr的朋友写的，我没改，可能是negative log probability吧。
There was a problem hiding this comment.
这个是之前pr的朋友写的，我没改，可能是negative log probability吧。
这个命名感觉不太好，可以在上方加一个带有全称的注释说明nlp的意义
ppsci/probability/hmc.py
Outdated
|
|
||
| acceptance = paddle.minimum( | ||
| paddle.to_tensor(1.0), paddle.exp((q0_nlp + p0_nlp) - (p1_nlp + q1_nlp)) | ||
| ) | ||
|
|
||
| # whether accept the proposed state position | ||
| event = paddle.uniform(shape=[], min=0, max=1) | ||
| event = self._rv_unif.sample([1]).squeeze() |
There was a problem hiding this comment.
paddle已经支持0-D tensor，可以试试直接使用[]
There was a problem hiding this comment.
完善一下每个函数的type hint，包括入参和返回类型
|
from ppsci import utils似乎会报错 其它的已经修改 |
这个应该是因为没有安装 |
OK那应该没问题了 |
|
hi, @NKNaN
|
luotao1
added
HappyOpenSource Pro
Describe
Future Work
如果需要达到和Pyro等一样的速度需要在采样时加入调整步长的功能。