[FastDeploy] support ppdet with fastdeploy on many hardwares #7950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhiboniu
reviewed
Mar 20, 2023
| import ast | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument( | ||
| "--model", required=True, help="Path of PaddleSeg model.") |
There was a problem hiding this comment.
- 笔误：PaddleSeg->PaddleDetection
- 建议改为--model_dir，与套件内其他使用习惯一致
| parser.add_argument( | ||
| "--model", required=True, help="Path of PaddleSeg model.") | ||
| parser.add_argument( | ||
| "--image", type=str, required=True, help="Path of test image file.") |
There was a problem hiding this comment.
建议改为--image_file或者--image_dir与套件其他地方习惯一致
|
|
||
| # settting for runtime | ||
| runtime_option = build_option(args) | ||
| model = fd.vision.detection.PPYOLOE( |
There was a problem hiding this comment.
关于这点，现在是在文档中进行说明。后续将会升级为，根据对arch关键字，直接通过读config文件来判断模型是否被支持，到时应该就只要一个类进行了，类似fastdeploy.vision.detection.PaddleDetectionModel这样子
zhiboniu
approved these changes
Apr 4, 2023
jerrywgz
approved these changes
Apr 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.