-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add im2sequence op #1239
base: develop
Are you sure you want to change the base?
add im2sequence op #1239
Conversation
huweidong01 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
赞,可否添加一个对应的单测?
auto input_info = GetInput("X"); | ||
auto output_info = GetOutput("Out"); | ||
|
||
std::vector<int64_t> kernels = kernels_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些变量似乎都没有用到,可以移除?
|
||
std::string reshaped_input = helper_->Reshape(input_info[0].name, new_shape); | ||
|
||
std::vector<int64_t> starts_i64(starts.begin(), starts.end()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里重新copy构造的原因是什么?
添加paddle im2sequence支持,精度待对齐