Forbid control flow related ops to constant folding #62206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
LGTM |
| @@ -78,7 +112,9 @@ void ConstantFoldingPass::ApplyImpl(ir::Graph *graph) const { | |||
| if (std::find(blacklist.begin(), blacklist.end(), op_node->Name()) != | |||
| blacklist.end()) | |||
| continue; | |||
|
|
|||
| if (OutputUsedByControlFlow(op_node, cf_vars)) { | |||
There was a problem hiding this comment.
这里显然只是想检测这个op_node的输出是否被控制流（while，condition_block）使用，我觉得可以在
这样是否也可以呢？
There was a problem hiding this comment.
也希望处理input var的情况，想象这么一种情况，控制流op与某个待折叠的op共享了一个权重输入，这时候还得在额外加一个for循环来处理，单个逻辑太分散，因此我就封装成了一个函数来调用
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Pcard-71500
Forbid control flow related ops to constant folding.