[PIR] Refine pir exe log && open some while test case for pir #60138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangbo9674
changed the title
winter-wang
reviewed
Dec 20, 2023
| ss << "end\n"; | ||
| VLOG(6) << ss.str(); | ||
| if (VLOG_IS_ON(2)) { | ||
| std::cout << "======================== pir interpreter trace order " |
There was a problem hiding this comment.
我记得好像有个规则是不允许使用std::cout.
There was a problem hiding this comment.
是的，当日志的字符串过长，使用 vlog 会出现截断的情况，这里通过 VLOG_IS_ON 来控制 cout 仅会在日志打印中出现
winter-wang
approved these changes
Dec 20, 2023
tianshuo78520a
approved these changes
Dec 20, 2023
HermitSun
pushed a commit
to HermitSun/Paddle
that referenced
this pull request
Dec 21, 2023
…Paddle#60138) * refine * fix * fix * fix * refine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Refine pir exe log && open some while test case for pir
Pcard-67164