【Hackathon 5th No.18】Add Binomial kernel for Hackthon No. 18 -part #59690

NKNaN · 2023-12-05T07:24:10Z

PR types

Others

PR changes

OPs

Description

Add Binomial kernel for Hackthon No. 18: pr #57856

paddle-bot · 2023-12-05T07:24:16Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

NKNaN · 2023-12-07T09:32:01Z

这个test总是超时，请问可以上调一下test的时间吗

luotao1 · 2023-12-07T09:34:05Z

可以的，你先上调下test时间看下。这个test大概需要多少时间？

NKNaN · 2023-12-07T09:38:42Z

PR-CI-Coverage里面看是15点多秒，超了一点

NKNaN · 2023-12-07T10:07:21Z

是在 CMakeLists.txt 里加时间吗，不太会这个，有没有参考

luotao1 · 2023-12-07T10:57:21Z

对的，你可以搜一下`PROPERTIES TIMEOUT`这样的写法

luotao1 · 2023-12-08T02:39:24Z

PR-CI-Coverage里面看是15点多秒，超了一点

那TIMEOUT放到30估计就够了，120太多了。可以等 @cxxly 其他意见一起修改

2023-12-08 06:06:47     Start 1352: test_binomial_op
2023-12-08 06:07:09     Test #1352: test_binomial_op .................   Passed   21.96 sec
2023-12-08 06:07:09     Start 1352: test_binomial_op
2023-12-08 06:07:29     Test #1352: test_binomial_op .................   Passed   20.11 sec
2023-12-08 06:07:29     Start 1352: test_binomial_op
2023-12-08 06:07:49 1/1 Test #1352: test_binomial_op .................   Passed   20.32 sec

NKNaN · 2023-12-08T02:52:23Z

那TIMEOUT放到30估计就够了，120太多了。可以等 @cxxly 其他意见一起修改

好的，谢谢

cxxly · 2023-12-08T03:34:33Z

python/paddle/tensor/random.py

@@ -102,6 +102,74 @@ def bernoulli(x, name=None):
        return out


+def binomial(total_count, prob, name=None):


同上，签名和torch保持一致

cxxly · 2023-12-08T03:34:59Z

paddle/phi/api/yaml/ops.yaml

@@ -323,6 +323,14 @@
    func: bincount
  optional: weights

+- op : binomial
+  args : (Tensor total_count, Tensor prob)


签名和torch一致，看了下第一个参数应该是count

cxxly · 2023-12-08T03:44:37Z

paddle/phi/infermeta/binary.h

+                       const MetaTensor& prob,
+                       MetaTensor* out,
+                       MetaConfig config = MetaConfig());
+


同上，签名统一修改下

cxxly · 2023-12-08T03:48:23Z

test/legacy_test/test_binomial_op.py

+
+    def verify_output(self, outs):
+        hist, prob = output_hist(np.array(outs[0]), self.n, self.p, a=5, b=15)
+        np.testing.assert_allclose(hist, prob, rtol=0, atol=0.01)


注明阈值设置参考标准

已注释，参照 test_bernoulli_op，test_poisson_op 和 test_multinomial_op

cxxly · 2023-12-08T03:49:29Z

test/legacy_test/test_binomial_op.py

+        if not paddle.is_compiled_with_cuda():
+            return
+
+        print("Test Fixed Random number on GPU------>")


删除print

cxxly · 2023-12-08T03:51:15Z

binomial设计与实现麻烦也补充到rfc，rfc与代码实现需要保持一致

zyfncg · 2023-12-08T05:00:48Z

paddle/phi/kernels/binomial_kernel.h

@@ -0,0 +1,37 @@
+// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.


2022 -> 2023

zyfncg · 2023-12-08T05:01:09Z

paddle/phi/kernels/cpu/binomial_kernel.cc

@@ -0,0 +1,42 @@
+// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.


zyfncg · 2023-12-08T05:05:32Z

paddle/phi/kernels/cpu/binomial_kernel.cc

+}  // namespace phi
+
+PD_REGISTER_KERNEL(
+    binomial, CPU, ALL_LAYOUT, phi::BinomialKernel, float, double) {}


输出固定为int64类型需要做类似如下的data type设置：

已修改，参照 multinomial 的

zyfncg · 2023-12-08T05:06:27Z

paddle/phi/kernels/funcs/binomial_functor.h

@@ -0,0 +1,134 @@
+/* Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.


2022 -> 2023

zyfncg · 2023-12-08T05:06:47Z

paddle/phi/kernels/gpu/binomial_kernel.cu

@@ -0,0 +1,199 @@
+/* Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.


2022 -> 2023

zyfncg · 2023-12-08T05:07:26Z

test/legacy_test/test_binomial_op.py

@@ -0,0 +1,272 @@
+#   Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.


2018 -> 2023

NKNaN · 2023-12-08T05:29:52Z

binomial设计与实现麻烦也补充到rfc，rfc与代码实现需要保持一致

好的，谢谢

cxxly

LGTM

jeff41404

LGTM

sunzhongkai588

LGTM，just 有一点疑问

sunzhongkai588 · 2023-12-13T08:16:55Z

python/paddle/tensor/random.py

+            >>> p = paddle.to_tensor([0.2, 0.6])
+            >>> out = paddle.binomial(n, p)
+            >>> print(out)
+            >>> # doctest: +SKIP("Random output")


加 seed 也不能固定输出吗？

啊，这里应该是固定的，文档抄过来没去掉 SKIP
需要去掉一下吗

@NKNaN 你再提一个PR改吧

NKNaN added 3 commits November 30, 2023 22:03

add kernel infermeta and yaml

7c37ebe

update infermeta

da7df25

add binomial kernel

0ee7c23

paddle-bot bot added the contributor External developers label Dec 5, 2023

luotao1 mentioned this pull request Dec 5, 2023

【PaddlePaddle Hackathon 5th】开源贡献个人挑战赛 #57262

Open

luotao1 added the PaddlePaddle Hackathon label Dec 5, 2023

luotao1 assigned luotao1 and cxxly Dec 5, 2023

NKNaN added 5 commits December 5, 2023 18:42

update cuda kernel

13aed38

update api

56a4069

update test

5e9e14c

update test

b3e5671

update test

b1f69fd

add test_binomial_op PROPERTIES TIMEOUT 120

f83357b

luotao1 changed the title ~~【Hackathon 5th No.18】Add Binomial kernel for Hackthon No. 18~~ 【Hackathon 5th No.18】Add Binomial kernel for Hackthon No. 18 -part Dec 8, 2023

update test_binomial_op PROPERTIES TIMEOUT 30

bef51dc

cxxly reviewed Dec 8, 2023

View reviewed changes

luotao1 assigned zyfncg Dec 8, 2023

zyfncg reviewed Dec 8, 2023

View reviewed changes

update

18a9af2

NKNaN added 2 commits December 8, 2023 18:48

fix test

cfa8724

update docs

c215189

NKNaN mentioned this pull request Dec 11, 2023

【Hackathon 5th No. 18】Add Binomial API -part PaddlePaddle/docs#6386

Merged

cxxly approved these changes Dec 12, 2023

View reviewed changes

jeff41404 approved these changes Dec 13, 2023

View reviewed changes

sunzhongkai588 approved these changes Dec 13, 2023

View reviewed changes

luotao1 merged commit 7b81bd8 into PaddlePaddle:develop Dec 13, 2023
28 of 29 checks passed

NKNaN deleted the hack18-kernel branch February 2, 2024 04:08

		@@ -102,6 +102,74 @@ def bernoulli(x, name=None):
		return out


		def binomial(total_count, prob, name=None):

		@@ -0,0 +1,37 @@
		// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.

		@@ -0,0 +1,42 @@
		// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.

		@@ -0,0 +1,134 @@
		/* Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.

		@@ -0,0 +1,199 @@
		/* Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.

		@@ -0,0 +1,272 @@
		# Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.

【Hackathon 5th No.18】Add Binomial kernel for Hackthon No. 18 -part #59690

【Hackathon 5th No.18】Add Binomial kernel for Hackthon No. 18 -part #59690

Conversation

NKNaN commented Dec 5, 2023

PR types

PR changes

Description

paddle-bot bot commented Dec 5, 2023

NKNaN commented Dec 7, 2023

luotao1 commented Dec 7, 2023

NKNaN commented Dec 7, 2023

NKNaN commented Dec 7, 2023

luotao1 commented Dec 7, 2023

luotao1 commented Dec 8, 2023 • edited Loading

NKNaN commented Dec 8, 2023

cxxly Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cxxly Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cxxly Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cxxly commented Dec 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NKNaN commented Dec 8, 2023

cxxly left a comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

sunzhongkai588 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luotao1 commented Dec 8, 2023 •

edited

Loading

cxxly Dec 8, 2023 •

edited

Loading

cxxly Dec 8, 2023 •

edited

Loading

cxxly Dec 8, 2023 •

edited

Loading