Remove No Used Indexing Code #59281
Merged
Remove No Used Indexing Code #59281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zoooo0820
force-pushed
the
remove_no_used_indexing_code
branch
from
76880db
to
f01fb01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-66985
Removed old indexing parsing code in Pybind and Python
For pybind code , since new indexing parsing for setitem and getitem was introduced in PR Move Dygraph Indexing Parsing to Pybind #58643 , it was no longer used in dygraph , will be removed.
For python code, it was remained before since there is no
index_putkernel for xpu. With this kernel, we can unify the indexing code for these device, and remove the old code.The unit test cases of
test_set_value_op_xpuwas modified, to keep it same to correspondingtest_set_value_op.